[kubo] Relay ignored options, is this done on purpose?

Help
1

Hello :wave:

I noticed while reading the kubo repository codebase RelayService (in this line https://github.com/ipfs/kubo/blob/master/core/node/libp2p/relay.go#L40) is applying **MaxReservations** user provided relay option to MaxReservationsPerIP, MaxReservationsPerPeer and MaxReservationsPerASN rather than applying their correspondent options. is this done on purpose ?

1 Like
2

This looks like a bug, nice catch.
Feel free to send a PR fixing this else I’ll do it later.

1 Like
3

thanks for the reply

here it’s fix(relay): apply user provider options [skip changelog] by asynxc · Pull Request #10026 · ipfs/kubo · GitHub

2 Likes